[Bug 238230] Review Request: perl-Catalyst-Action-RenderView - Sensible default end action for view renders
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jun 6 06:33:28 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Action-RenderView - Sensible default end action for view renders
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238230
------- Additional Comments From panemade at gmail.com 2007-06-06 02:33 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
95f0e438c073efa5e0930eda00304136 Catalyst-Action-RenderView-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
+ ./Build test
t/01use............ok
t/02pod............ok
t/03podcoverage....skipped
all skipped: set TEST_POD_COVER to enable this test
t/04live...........[debug] Debug messages enabled
[debug] Loaded dispatcher "Catalyst::Dispatcher"
[debug] Loaded engine "Catalyst::Engine::CGI"
[debug] Found home
"/builddir/build/BUILD/Catalyst-Action-RenderView-0.04/t/lib/TestApp"
[debug] Loaded components:
.-----------------------------------------------------------------+----------.
| Class | Type |
+-----------------------------------------------------------------+----------+
| TestApp::View::TestView | instance |
'-----------------------------------------------------------------+----------'
[debug] Loaded Private actions:
.----------------------+--------------------------------------+--------------.
| Private | Class | Method |
+----------------------+--------------------------------------+--------------+
| /test_firstview | TestApp | test_firstv- |
| | | iew |
| /end | TestApp | end |
| /test_view | TestApp | test_view |
| /test_skipview | TestApp | test_skipvi- |
| | | ew |
'----------------------+--------------------------------------+--------------'
[debug] Loaded Path actions:
.-------------------------------------+--------------------------------------.
| Path | Private |
+-------------------------------------+--------------------------------------+
| /test_firstview | /test_firstview |
| /test_skipview | /test_skipview |
| /test_view | /test_view |
'-------------------------------------+--------------------------------------'
[info] TestApp powered by Catalyst 5.7007
[info] *** Request 1 (1.000/s) [8462] [Wed Jun 6 00:09:17 2007] ***
[debug] "GET" request for "test_firstview" from "127.0.0.1"
[debug] Path is "test_firstview"
[info] Request took 0.016447s (60.801/s)
.----------------------------------------------------------------+-----------.
| Action | Time |
+----------------------------------------------------------------+-----------+
| /test_firstview | 0.000442s |
| /end | 0.004766s |
| -> TestApp::View::TestView->process | 0.000071s |
'----------------------------------------------------------------+-----------'
[info] *** Request 2 (2.000/s) [8462] [Wed Jun 6 00:09:17 2007] ***
[debug] "GET" request for "test_view" from "127.0.0.1"
[debug] Path is "test_view"
[info] Request took 0.009183s (108.897/s)
.----------------------------------------------------------------+-----------.
| Action | Time |
+----------------------------------------------------------------+-----------+
| /test_view | 0.000167s |
| /end | 0.002264s |
| -> TestApp::View::TestView->process | 0.000049s |
'----------------------------------------------------------------+-----------'
[info] *** Request 3 (3.000/s) [8462] [Wed Jun 6 00:09:17 2007] ***
[debug] "GET" request for "test_skipview" from "127.0.0.1"
[debug] Path is "test_skipview"
[info] Request took 0.005515s (181.324/s)
.----------------------------------------------------------------+-----------.
| Action | Time |
+----------------------------------------------------------------+-----------+
| /test_skipview | 0.000044s |
| /end | 0.000172s |
'----------------------------------------------------------------+-----------'
ok
All tests successful, 1 test skipped.
Files=4, Tests=17, 1 wallclock secs ( 0.50 cusr + 0.08 csys = 0.58 CPU)
+ Provides: perl(Catalyst::Action::RenderView)
+ Requires: perl(:MODULE_COMPAT_5.8.8) perl(Catalyst) perl(Catalyst) >= 5.7
perl(Catalyst::Action) perl(base)
Can we go with approving this with failed tests? I don't think so.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list