[Bug 227291] Review Request: ptunnel - Reliably tunnel TCP connections over ICMP packets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ptunnel - Reliably tunnel TCP connections over ICMP packets


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227291


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium

mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-06-06 14:30 EST -------
Some notes:

* invalid macro
-------------------------------------------------
%define VER %(rpmquery --qf '%{VERSION}' fedora-release)
-------------------------------------------------
  - This won't work for two reason.
  * First the current rawhide returns the value VER as 7.89,
    not integer
  * And calling rpm command in rpmbuild is regarded as dangerous.
    Instead you can use %fedora macro. 
--------------------------------------------------
%if 0%{?fedora} <= 5
BuildRequires:  libpcap
%else
BuildRequires:  libpcap-devel
%endif
---------------------------------------------------

* optflags
  - This spec file does not honor fedora specific compilation
    flags.
---------------------------------------------------
+ make
gcc -Wall -g -MM *.c > .depend
gcc -Wall -g -c -o ptunnel.o ptunnel.c
gcc -Wall -g -c -o md5.o md5.c
gcc -o ptunnel ptunnel.o md5.o -lpthread -lpcap
--------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.