[Bug 239939] Review Request: libgii - General Graphics Interface toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgii - General Graphics Interface toolkit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239939





------- Additional Comments From matthias at rpmforge.net  2007-06-07 03:33 EST -------
Further comments :
- I think exporting CFLAGS and CXXFLAGS is redundant (%configure does that)
- Setting "--libdir=%{_libdir}" is redundant (%configure does that)
- The 's|LDFLAGS =  -L/usr/lib|LDFLAGS =  -L%{_libdir}|' substitution seems a
little dangerous, as if the next version has "LDFLAGS =  -L/usr/lib64" somehow,
you're going to be replacing it with /usr/lib6464 on 64bit archs. A more solid
fix could only be better.
- You forgot one last %dir in -devel : %dir %{_includedir}/ggi/
- I don't think the %dirs under %{_sysconfdir} should be in the -devel too.

Other than that it's already looking better ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.