[Bug 242651] Review Request: perl-Mail-Audit - something flexible to filter mail using Perl tests.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Mail-Audit -  something flexible to filter mail using Perl tests.
Alias: perl-Mail-Audit

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242651


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cweyl at alumni.drew.edu
OtherBugsDependingO|                            |177841
              nThis|                            |
              Alias|                            |perl-Mail-Audit




------- Additional Comments From cweyl at alumni.drew.edu  2007-06-07 13:08 EST -------
A couple comments... check out bug 242311 's comments also :)

The man pages must not be marked as %doc.  %doc is for random
documentation/examples/tests/etc that are useful but don't fit anywhere else.

There must be a %check section.

The perl_vendorlib/etc %defines at the top my raise some eyebrows; they haven't
really been needed since...  um.  RHEL3 days?  RHL9?  A review will probably
insist you either take them out, or conditionalize them such that the local
definitions aren't defined to the system already, a la:

%{?!perl_vendorlib: ...}

I'd just nix them, personally, unless you can make a case for needing them
somewhere.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.