[Bug 227669] Review Request: ppl-0.9 - A modern C++ library providing numerical abstractions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ppl-0.9 - A modern C++ library providing numerical abstractions


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227669





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-06-07 13:09 EST -------
Created an attachment (id=156485)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=156485&action=view)
rpmlint check result for ppl 0.9-6

NOTE: From next time, please bump (increment) the release number
      of spec file each time you modify spec file.
      http://fedoraproject.org/wiki/Packaging/FrequentlyMadeMistakes

* Must/Should be fixed
! Notes
? Questions
= Okay

Now I am reviewing formally. For 0.9-6:

* Source
  - The source in your srpm differ from what I downloaded
    from the URL on your spec file??
-----------------------------------------------------------------
[tasaka1 at localhost ppl]$ ls -al *gz */*gz
-rw-rw-r-- 1 tasaka1 tasaka1 6330518 2007-02-11 05:43
ppl-0.9-6.fc8/ppl-0.9.tar.gz
-rw------- 1 tasaka1 tasaka1 6023797 2006-03-12 00:00 ppl-0.9.tar.gz
[tasaka1 at localhost ppl]$ md5sum *gz */*gz
4096c2927b36fbf7c5329a53b035bc33  ppl-0.9.tar.gz
4c92a57a851b53e57d63aa64f2bd1f3a  ppl-0.9-6.fc8/ppl-0.9.tar.gz
-----------------------------------------------------------------
* rpmlint
  The result of rpmlint for srpm, binary rpms and the installed
  rpms is attached.

  SUMMARY:
  * Undefined non-weak symbols
    - Two libraries have undefined non-weak symbols. For rpms which want to
      provide also -devel subpackages, this cannot be allowed because linkage
      against these libraries fails because of these symbols.

  * devel packge dependency on non-devel package
    - Please explain
      * why ppl-swiprolog requires ncurses-devel
      * why ppl-utils requires glpk-devel
      Usually non-devel packages should not require devel related
      packages.

    = All other rpmlint complaints can be ignored.

* Unwanted call of autotools after configure
  - Mock build log (will attach) says:
----------------------------------------------------------
+ make
cd . && /bin/sh /builddir/build/BUILD/ppl-0.9/missing --run aclocal-1.9 -I m4
/builddir/build/BUILD/ppl-0.9/missing: line 51: aclocal-1.9: command not found
WARNING: `aclocal-1.9' is missing on your system.  You should only need it if
<snip>
/bin/sh ./config.status --recheck
----------------------------------------------------------
  - Automated call of autotools and recall of config.status
    is wrong. Perhaps the timestamps of configure vs configure.ac
    are incorrect.

* Timestamps
  - For make install, please use (for this package)
----------------------------------------------------------
make DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p" install
----------------------------------------------------------
    Actually this package tries to install many documentaion/
    image files/etc..., which are not modified or created during
    rebuild and keeping timestamps on those files is recommended.

* Definitions in header files
  - Some definitions in some header files are very dangerous
    and may easyly cause definition conflict.
    For example, /usr/include/ppl.hh has some definitions such that
-----------------------------------------------------------
#define HAVE_SYS_TYPES_H 1
#define HAVE_UNISTD_H 1
-----------------------------------------------------------
    ... etc. These definition names are too generic and may cause
    conflicts on definition name space when other header files
    from other packages are included.

    Generally, these types of generic "#define" macro should be
    included in header files.
    Remove unneeded (and dangerous) #define and #ifdef macros
    or change the names of macros to less generic.

  - And note that #ifdef macros are generally unhappy. At least
    please ensure that #ifdef judgment does not affect the ABI
    of the libraries.

    (Same for /usr/include/pwl.hh in -pwl-devel package)

* About libppl_gprolog.so:
---------------------------------------------------------
[mockbuild at localhost ~]$ ppl_gprolog 
ppl_gprolog: error while loading shared libraries: libppl_gprolog.so: cannot
open shared object file: No such file or directory
---------------------------------------------------------
  * ppl_gprolog is not launched. Perhaps
    - ppl_gprolog should be moved to where is not included in
      default path
    - or libppl_gprolog.so should be moved to where ldconfig
      checks
    - or ppl_gprolog should have rpath for %{_libdir}/%{name}
    - or something else?


=========================================================
  I have not checked for documentation yet, but please
  fix above.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.