[Bug 241075] Review Request: redet - Regular expression development and execution tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: redet - Regular expression development and execution tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241075


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-06-07 23:02 EST -------
Sorry it's taken me three days to get back to this.

It's fine if you put off the manpage bit; it's kind of pointless to compress it
yourself but I don't think it's a blocker.

Unfortunately this fails to build in mock for me; you just need to add a build
dependency on desktop-file-utils and everything goes through fine.

I installed on my desktop and found a problem with the desktop file: It has no
GenericName entry, so instead of "Redet (Regular expression whatever)" I just
get "Redet".  I would recommend replacing "Comment" with "GenericName" in your
desktop file, but the desktop entry spec doesn't require GenericName so I don't
think it's a blocker.

I am not sure if TCL actually supports StartupNotify=true, but startup
notification seems to work well enough for me under KDE so I suppose it's OK.

So since there's only one remaining trivial blocker and it will keep you from
actually building the package, I'll go ahead and approve this and you can fix it
when you check in.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.