[Bug 225690] Merge Review: dhcdbd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: dhcdbd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225690


clumens at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?(dcantrell at redhat.c
                   |                            |om)




------- Additional Comments From clumens at redhat.com  2007-06-08 16:56 EST -------
rpmlint output:
W: dhcdbd macro-in-%changelog post
W: dhcdbd macro-in-%changelog doc
E: dhcdbd no-cleaning-of-buildroot %install

macro usage:
Should Patch0 be specified with %{name}-%{version}-initscript.patch, and the
same for Patch1?

Requires:
Remember that we don't like file requires, so you could just Requires(...)
chkconfig and initscripts.  The guidelines say it's allowed as long as the files
are in /sbin, though.  Your call.

Scriptlets:
Be consistent about checking conditions before running the preun and postun
scriptlets.  Right now, they use different forms of the same test. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.