[Bug 241761] Review Request: professor-is-missing - An AGI adventure game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: professor-is-missing - An AGI adventure game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-06-08 22:05 EST -------
rpmlint says just:
   E: professor-is-missing zero-length /usr/share/professor-is-missing/snddir
My understanding is that this empty directory is necessary for nagi, else it
segfaults.  Which would be a bug perhaps worth fixing, but probably shouldn't
hold up AGI packages.

BTW, you can downcase a bunch of filenames with something like
  for i in *; do
    j=`echo $i|tr '[A-Z]' '[a-z]'`
    if [ $i != $j ]; then
      mv $i $j
    fi
  done

* source files match upstream.  Manually compared exploded Source0 with the 
  upsteam zipfile:
   Only in upstream: Agi
   Only in upstream: AGIDATA.OVL
   Only in upstream: CGA_GRAF.OVL
   Only in upstream: EGA_GRAF.OVL
   Only in upstream: HGC_FONT
   Only in upstream: HGC_GRAF.OVL
   Only in upstream: HGC_OBJS.OVL
   Only in upstream: IBM_OBJS.OVL
   Only in upstream: JR_GRAF.OVL
   Only in upstream: prof.com
   Only in upstream: VG_GRAF.OVL
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is acceptable for content in Fedora.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint has only unavoidable complaints.
* final provides and requires are sane:
   professor-is-missing = 0.1-3.fc8
  =
   /bin/bash
   /bin/sh
   hicolor-icon-theme
   nagi
* %check is not present; no test suite.  I played for a few minutes and managed 
  no score no points at all.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* contains acceptable content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* desktop file looks OK and is installed properly.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.