[Bug 227669] Review Request: ppl - A modern C++ library providing numerical abstractions

bugzilla at redhat.com bugzilla at redhat.com
Sat Jun 9 17:25:39 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ppl - A modern C++ library providing numerical abstractions


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227669





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-06-09 13:25 EST -------
Well, for 0.9-7:

* %check
  - This package contains test/ directory and some
    check programs seem to be executed. If "make check"
    makes sense, please add:
--------------------------------------------------
%check
make check
--------------------------------------------------
    (Well, this is very very long...)

* Documentation
  - It seems that README.configure is for people who want to
    rebuild ppl by themselves (i.e. who want to call configure
    by themselves) and so IMO this document should be removed
    for rpm user.

  - IMO TODO should be added to documents.

* %description
  - Please refrect static archive split. For example,
    -devel package says:
---------------------------------------------------
%description devel
The header files, documentation and static libraries for developing
                                ^^^^^^^^^^^^^^^^^^^^
---------------------------------------------------

* rpath issue
  - As said above, please let me know if rpath issue is
    resolved by hacking libtool.

All other things are okay.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list