[Bug 241903] Review Request: etherbat - Ethernet topology discovery

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: etherbat - Ethernet topology discovery


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241903


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2007-06-09 18:51 EST -------
I always build in rawhide.  However, I also always build on x86_64 which is the
problem here.  The library lives in /usr/lib64/libnet.a on that platform.  In
additionm, the compiler isn't called with the proper set of flags.  This breaks
the debuginfo package.

To fix these, you just need to change the make line to
   CFLAGS="$RPM_OPT_FLAGS" make LIBNET_STATIC=%{_libdir}/libnet.a
and everything builds fine.

Unfortunately this does a static link, and according to the current rules this
needs to go through FESCo.  Ugh.  And it's possible that they won't approve it,
because it's possible to have a dynamic libnet.  (Debian ships it as a dynamic
lib, for example.)

Review:
* source files match upstream:
   2245dab0a9db77e4a742e3bf07862161de6623f46ae063312c38e32c8fb344f9  
   etherbat-1.0.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
X compiler flags not correct.
* %clean is present.
X package fails to build in mock (development, x86_64)
* package installs properly (once build is fixed, at least)
X debuginfo package is incomplete.
* rpmlint is silent (once build is fixed)
* final provides and requires are sane:
   etherbat = 1.0.1-1.fc8
  =
   /usr/bin/ruby
   libglib-2.0.so.0()(64bit)
   libpcap.so.0.9()(64bit)
   ruby
* %check is not present; no test suite upstream.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.