[Bug 218577] Review Request: glump - A small web application to glue files from multiple sources

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glump - A small web application to glue files from multiple sources


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218577





------- Additional Comments From tibbs at math.uh.edu  2007-06-09 22:14 EST -------
Crap, I was typing this up but had to break for dinner before I could submit it.  Here's what I wrote:

rpmlint output is OK:

W: glump mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13)
  Not a blocker; fix it if you wish.

E: glump explicit-lib-dependency libxml2-python
  This is a false positive.  The package is necessary, and the dependency 
  generator doesn't find it automatically.

Marek is right; you should clean the buildroot at the beginning of install.  Usually rpmlint complains about that; I'm not sure why it didn't.

* source files match upstream:
   634325e4efb057c5b849bf831a51ce8e7e11cec572b6769e9645f06443ae51ab  
   glump-0.9.11.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint has only acceptable complaints.
* final provides and requires are sane:
   config(glump) = 0.9.11-2.fc8
   glump = 0.9.11-2.fc8
  =
   /usr/bin/python
   config(glump) = 0.9.11-2.fc8
   httpd
   libxml2-python
   mod_python
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.