[Bug 243571] Review Request: python-mechanoid - Python Programmatic Web Browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-mechanoid - Python Programmatic Web Browser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243571


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2007-06-09 23:32 EST -------
This failed to build for me:
+ /usr/bin/python setup.py install -O1 --skip-build --root
/var/tmp/python-mechanoid-0.6.9-1.fc8-root-mockbuild
running install
error: invalid Python installation: unable to open
/usr/lib64/python2.5/config/Makefile (No such file or directory)
error: Bad exit status from /var/tmp/rpm-tmp.12975 (%install)

You need a build dependency on python-devel.  Adding it gets things building.

rpmlint says:
  W: python-mechanoid wrong-file-end-of-line-encoding 
   /usr/share/doc/python-mechanoid-0.6.9/COPYING
and indeed that file seems to have come from DOS and needs fixing.

The package has a test suite, and it almost runs, but because DNS is not
configured in mock, this fails:
  socket.gethostbyname(socket.gethostname())
which makes a single test (out of 116) fail.  It may be worth patching out to
get some test coverage, but then it might become a pain because nothing stops
them from adding more network-using tests in the future.

If you don't want to add the test suite, do go ahead and add a %check section
with the line for running the tests commented out so that folks who want to run
it themselves can easily do so.

Review:
* source files match upstream:
   e6d39a80993055466be234d279f08a42fdd51896ad19e13024b54ff226b8c990  
   mechanoid-0.6.9.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
X BuildRequires missing python-devel.
* %clean is present.
* package builds in mock (development, x86_64) after adding missing BR.
* package installs properly
X rpmlint has a valid complaint.
* final provides and requires are sane:
   python-mechanoid = 0.6.9-1.fc8
  =
   python(abi) = 2.5
* %check is not present; one test cannot be run in mock.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.