[Bug 243607] Review Request: gengetopt - Tool to write command line option parsing code for C programs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gengetopt - Tool to write command line option parsing code for C programs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243607


mmahut at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmahut at redhat.com




------- Additional Comments From mmahut at redhat.com  2007-06-10 14:44 EST -------
REVIEW
======

+ source files match upstream.
        b78cbb10356ce67d1d22436bce59dbdf  gengetopt-2.19.1.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
+ license is open source-compatible.
+ license text included in package.
+ latest version is being packaged.
- it's recommended to fill dynamic sources like
    Source0: ftp://ftp.gnu.org/gnu/%{name}/%{name}-%{version}.tar.gz
- build of SRPM fails:

     error: Installed (but unpackaged) file(s) found:
        /usr/share/info/dir


     RPM build errors:
         Installed (but unpackaged) file(s) found:
   /usr/share/info/dir

Also don't forget to include for textinfo

     Requires(post): /sbin/install-info
     Requires(preun): /sbin/install-info

Please, correct those errors first.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.