[Bug 225692] Merge Review: dhcpv6

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: dhcpv6


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225692





------- Additional Comments From clumens at redhat.com  2007-06-11 14:30 EST -------
W: dhcpv6 prereq-use /sbin/chkconfig, /sbin/service
W: dhcpv6 macro-in-%changelog defattr

%preun and %postun should use the same form of test for whether to run or not.

%attr(750,root,root) %dir %{_localstatedir}/lib/dhcpv6 should use %{name}.

These should use %{_sysconfdir}/sysconfig/... :
%config(noreplace) /etc/sysconfig/dhcp6s
%config(noreplace) /etc/sysconfig/dhcp6r

These should use %{_initrddir}/... :
%attr(755,root,root) %config /etc/rc.d/init.d/dhcp6s
%attr(755,root,root) %config /etc/rc.d/init.d/dhcp6r

You use $RPM_BUILD_ROOT in %clean, but %{buildroot} everywhere else.

The static library needs to be in a dhcpv6-static package.

libdhcp6client-devel needs to Require: pkgconfig, %{name} = %{version}-%{release}.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.