[Bug 226459] Merge Review: system-config-kickstart

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-kickstart


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226459


clumens at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(clumens at redhat.com|
                   |)                           |




------- Additional Comments From clumens at redhat.com  2007-06-11 15:21 EST -------
> W: system-config-kickstart summary-ended-with-dot A graphical interface for
> making kickstart files.

Fixed.

> E: system-config-kickstart tag-not-utf8 %changelog
> E: system-config-kickstart non-utf8-spec-file system-config-kickstart.spec
> W: system-config-kickstart macro-in-%changelog packages
> W: system-config-kickstart macro-in-%changelog doc

I think the first two are complaining about someone's name in a changelog entry
from 2002.  All of these require going back and modifying the changelog, which
I'm not really excited about doing unless I absolutely have to.

> W: system-config-kickstart no-%build-section
> 
> The Source0 field should contain the URL to the downloadable source or a comment
> like this above it:
> 
> # This is a Red Hat maintained package which is specific to
> # our distribution.  Thus the source is only available from
> # within this srpm.
> 
> BuildRoot should be:
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> 
> Personal opinion: group Obsoletes, BuildRequires, and Requires items on to a
> smaller number of lines?
> 
> %{buildroot} vs. $RPM_BUILD_ROOT
> 
> Line 17 has a trailing space.
> 
> In %files, use %defattr(-,root,root,-)
> 
> Use path macros in %files section.
> 
> Make sure desktop-file-install usage is per the guidelines:
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6

Fixed.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.