[Bug 242539] Review Request: freetds - Implementation of the Sybase/Microsoft TDS (Tabular DataStream) protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freetds - Implementation of the Sybase/Microsoft TDS (Tabular DataStream) protocol


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242539


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |j.w.r.degoede at hhs.nl
               Flag|                            |fedora-review+




------- Additional Comments From j.w.r.degoede at hhs.nl  2007-06-11 15:48 EST -------
MUST:
=====
* rpmlint output is:
W: freetds strange-permission freetds.spec 0666
W: freetds strange-permission freetds-0.64-makefile-doc.patch 0666
W: freetds strange-permission freetds-0.64.tar.gz 0666
# You should check these, might be something with my setup though
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel x86_64
* BR: ok
* No locales
* Shared libraries, ldconfig run as required
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* -devel package as needed
* no .desktop file required

Should Fix
==========
* This:
cr=`echo -en '\r'`
sed -i "s/$cr//" doc/tds_ssl.html
Is a rather convoluted way of saying this:
sed -i 's/\r//' doc/tds_ssl.html

About the trademarks in the description, I think there is no other sensible way
to describe this package and that the TM use is a typical case of fair use.

You might want to add a sentence: "All trademarks are the property of their
respective owners".

I see no blockers, approved!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.