[Bug 236521] Review Request: nspluginwrapper - A compatibility layer for Mozilla/Firefox plugins

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nspluginwrapper - A compatibility layer for Mozilla/Firefox plugins
Alias: nspluginwrapper

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236521





------- Additional Comments From stransky at redhat.com  2007-06-13 14:14 EST -------
(In reply to comment #59)

Great, thanks for the suggestions, we can move forward now.

> [root at newcaprica mock]# rpm -ivh
> fedora-7-i386/result/nspluginwrapper-0.9.91.4-3.fc7.i386.rpm
> fedora-7-x86_64/result/nspluginwrapper-0.9.91.4-3.fc7.x86_64.rpm 
> Preparing...                ########################################### [100%]
>    1:nspluginwrapper        ########################################### [ 50%]
> Installing plug-ins for 64-bit browser...
>    2:nspluginwrapper        ########################################### [100%]
> Installing all plug-ins...
> Install plugin /usr/lib/mozilla/plugins-backup/libflashplayer.so
>   into /usr/lib/mozilla/plugins/npwrapper.libflashplayer.so
> Install plugin /usr/lib/mozilla/plugins-backup/libflashplayer.so
>   into /usr/lib64/mozilla/plugins/npwrapper.libflashplayer.so
> 
> 1) You must quiet these messages during %post and %preun.  Redirect the output
> to /dev/null.

okay.

> 2) Please offload the list of plugins to wrap to /etc/sysconfig/nspluginwrapper
> or someplace.  It must be possible for users to edit the list and have it
> survive package upgrades.

okay, makes sense

> 3) Please allow a config boolean like WRAPALL=yes or WRAPALL=no for users to
> enable wrapping of all plugins if they wish it.  (It would of course need to
> avoid wrapping itself or already wrapped plugins...)

It should be a part of /etc/sysconfig/nspluginwrapper, right?

> 4) Cross-compile with --target=i386 fails here, although my builds done in mock
> on both archs work.  I think it isn't necessary to fix cross-compile but it
> would be nice.
> 
> ~/rpmbuild/BUILD/nspluginwrapper-0.9.91.4/objs-32
> ~/rpmbuild/BUILD/nspluginwrapper-0.9.91.4
> + ../configure --prefix=/usr --target-cpu=i386 --pkgdir=nspluginwrapper
> --pkglibdir=/usr/lib/nspluginwrapper --with-lib32=lib --with-lib64=lib64
> --with-base-lib=lib64 --with-base-libdir=/usr/lib --with-x11-prefix=/usr
> GTK+ 2.0 environment not usable
> error: Bad exit status from /var/tmp/rpm-tmp.3311 (%build)

You may miss some 32-bit library (i got this message for missing cairo-devel.i386) 
 
> 5) Decide whether you want to use this packaging or the alternative that dwmw2
> prefers.  I don't want to decide that.

Definitely this one. It consists from only one package for each architecture
what contains everything what's important (wrapper&viewer) and meets all
cailon's requests.

> 6) *PLEASE* allow ppc builds before the initial version of this goes into the
> repo.  It really wont take much to make it buildable.

okay, i'll check that.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.