[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086


tyler.l.owen at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyler.l.owen at gmail.com




------- Additional Comments From tyler.l.owen at gmail.com  2007-06-13 19:28 EST -------
On Fedora Core 7:

* rpmlint is silent
* RPM/specfile name looks good
* Group looks good
* License is open-source compatible (GPL)
* COPYING included in source and included in %doc
* SPEC file is in English

- FIX : SPEC file %description not legible 
  it does not read very well (which I saw is directly from the README in the
upstream tarball)

* Source is the same as upstream
* Package builds cleanly in mock for Fedora 7 i386
* Handles locales properly (uses %find_lang)
* Package not relocatable
* Package owns all directories it creates
* No dupes in %files
* Files section contains %defattr(-,root,root,-)
* Valid clean section
* Macro usage looks good
* No large docs
* No shared libs
* No header files, static libs or *.pc files
* No libtool archives
* .desktop file included as Source1
- FIX: <vendor_id> set to blank ("") in desktop-file-install, per packaging
guidelines (http://fedoraproject.org/wiki/Packaging/Guidelines#desktop) should
be fedora is not specified by upstream

* Install starts with  rm -rf $RPM_BUILD_ROOT
* RPM installs and runs without an issue on Fedora 7 i386

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.