[Bug 226337] Merge Review: pyparted

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: pyparted


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226337


dcantrell at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(dcantrell at redhat.c|
                   |om)                         |




------- Additional Comments From dcantrell at redhat.com  2007-06-14 15:21 EST -------
(In reply to comment #5)
> 1. Please add back the "rm -fR buildroot" line in %install, looks like it was
> deleted by accident when editing the make line

Done.

> 2. The description tag says "it is used for manipulation partition tables". I am
> not a native English speaker, but to me it looks like a cat has eaten a word. I
> suggest "[...] used for manipulation of partition tables" or "[...] used for
> manipulating partition tables"

Done.  It's 'manipulating partition tables'.

> 3. The Summary field says "python module for..." while the Desc field starts
> with "python modules for". How about sticking with either singular (module) or
> plural (modules) ?

Done.  It's 'Python module'.

> 4. The makefile mentions the need of pkg-config since version 1.8.3. However
> there is no .pc file and the spurious call to pkg-config (via LDFLAGS) leads to
> an error message in the build log. I suggest either using the already existing
> Makefile patch to remove the call to pkg-config or requiring pkg-config if the
> .pc will come back.

The pkgconfig file is there.  I've added a BuildRequire for pkgconfig.

New version is pyparted-1.8.8-1.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.