[Bug 244262] Review Request: perl-CGI-FormBuilder - Easily generate and process stateful forms

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CGI-FormBuilder - Easily generate and process stateful forms
Alias: perl-CGI-FormBuilder

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244262


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cweyl at alumni.drew.edu
              Alias|                            |perl-CGI-FormBuilder




------- Additional Comments From cweyl at alumni.drew.edu  2007-06-15 10:35 EST -------
Hey Jeff -- couple quick spec notes:

BR'ing perl is ok, but depreciated if you don't need to specify a specific
version of perl (e.g. 1:5.006).

BR'ing perl-devel is strongly discouraged, even if wrapped in a conditional (and
if I were doing a full review right now I would consider it a blocker). 
Instead, the canonical approach is to add BR's on certain core modules that have
been deemed devel and split off: See
http://fedoraproject.org/wiki/PackagingDrafts/Perl#requiresandprovides. 

The README notes the license as standard perl, that is "GPL or Artistic", but
your spec notes the license as just GPL.

There are a number of "optional" modules noted in Makefile.PL; maybe they're not
needed for build but it looks to be that the tests will require them, e.g.:

2d-template-fast....ok                                                       
        4/4 skipped: skip: CGI::FastTemplate not installed here


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.