[Bug 244222] Review Request: perl-CGI-FastTemplate - Perl extension for managing templates, and performing variable interpolation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CGI-FastTemplate - Perl extension for managing templates, and performing variable interpolation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244222


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-06-15 16:10 EST -------
Not much to say here; builds fine and rpmlint is quiet.

I guess if I really wanted to pick nits, there's a comma fault in Summary.

* source files match upstream:
   7d9d6b57bef2c3a33142c4cf0ca07d8801575e53b7f054b83df9f616bd2a7773  
   CGI-FastTemplate-1.09.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(CGI::FastTemplate)
   perl-CGI-FastTemplate = 1.09-2.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(strict)
* %check is present and all tests pass:
   All tests successful.
   Files=5, Tests=10,  0 wallclock secs ( 0.05 cusr +  0.05 csys =  0.10 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.