[Bug 243665] Review Request: perl-Geo-IP - Efficient GeoIP bindings for Perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Geo-IP - Efficient GeoIP bindings for Perl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243665





------- Additional Comments From tibbs at math.uh.edu  2007-06-15 14:24 EST -------
Heh, you beat me to this.  I just used cpanspec to generate mine.

Some comments:

License is GPL or Artistic, not GPL, at least according to my reading of the
README file.

I referenced the module in the ususl CPAN locations:

URL:            http://search.cpan.org/dist/Geo-IP/
Source0:       
http://www.cpan.org/authors/id/T/TJ/TJMATHER/Geo-IP-%{version}.tar.gz

I guess it doesn't really matter either way, but CPAN is usually the canonical
location for Perl modules.

Please remove the "mf" from Release:.

When adding Perl module dependencies, please depend on the perl() symbol and not
the package name: perl(ExtUtils::MakeMaker).  There is no guarantee that the
module will stay in a separate package.

The package has a test suite; any reason for not running it?

Any reason not to package the example directory as documentation?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.