[Bug 244623] Review Request: OggConvert - OggConvert is a small GNOME utility that uses GStreamer to convert media files to the licence-free Theora and Vorbis formats.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OggConvert - OggConvert is a small GNOME utility that uses GStreamer to convert media files to the licence-free Theora and Vorbis formats.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244623


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

tyler.l.owen at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyler.l.owen at gmail.com




------- Additional Comments From tyler.l.owen at gmail.com  2007-06-18 22:05 EST -------
This is not an official review as I am not sponsored, but I helps!  

-------------------------------------------
Execute Summary:
-------------------------------------------
* rpmlint not silent
* Mock failed to build
* Changelog not correct - missing version info
* License in SPEC should be LGPL instead of GNU LGPL
* %files needs work.  It installs files without the RPM owning, and tries to own
directories it should not
* Desktop file not installed correctly

-------------------------------------------
Details:
-------------------------------------------

 FIX - Mock : Does not build.  Attempted on F-7 (x86)
 OK - Package meets naming and packaging guidelines
 OK - Spec file matches base package name.
 OK - Spec has consistant macro usage.
 FIX - Meets Packaging Guidelines.
        * Files section needs work
 FIX - License field in spec matches - should be LGPL instead of GNU LGPL
 OK - License is Open Souce - LGPL
 OK - License match extras packaging policy licenses allowed
 OK - License file is included in package
 OK - Spec in American English
 OK - Spec is legible.
 OK - Sources SHOULD match upstream md5sum:
a825bf00977e3410f9009198dbcc1fbb  oggconvert-0.2.0.tar.gz
 OK - Package has correct buildroot.
 OK - extras BuildRequires are not redundant.
 ? - %build and %install stages are correct and work.
 OK - Package has %defattr and permissions on files is good.
 OK - Package has a correct %clean section.
 OK - Package is code or permissible content.
 OK - Packages %doc files don't affect runtime.
 OK - Package has no duplicate files in %files.
 FIX - Package doesn't own any directories that other packages own.
        Package tries to own %{_bindir}/*
 FIX - Changelog section is missing version numbers for each entry. 
 FIX - Desktop file not installed using desktop-file-install (see
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop for procedure)
 ? - Should function as described.
 OK - Should package latest version

-------------------------------------------
Rpmlint output:
-------------------------------------------
FIX - SRPM not silent
        rpmlint oggconvert-0.2.0-2.fc7.src.rpm 
        E: oggconvert description-line-too-long OggConvert is a small GNOME
utility that uses GStreamer to convert media files to the licence-free Theora
and Vorbis formats.
        E: oggconvert description-line-too-long * It's painfully easy to use:
drag a file onto the source bar (or use the file chooser) and hit convert. Of
course, you can also change the quality settings and the output filename if you
like.
        E: oggconvert description-line-too-long * It can deal with audio-only
files, video-only files, and files with many audio tracks (such as DVD rips with
a commentary track).
        E: oggconvert description-line-too-long * Thanks to the magic of
GStreamer, metadata (for example, title and artist info on an MP3) is preserved
        W: oggconvert non-standard-group Applications/AudioVideo
        W: oggconvert invalid-license GNU LGPL
        E: oggconvert unknown-key GPG#ef98a217
        W: oggconvert mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 13)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.