[Bug 244936] Review Request: dbench - Filesystem load benchmarking tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dbench - Filesystem load benchmarking tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244936


tyler.l.owen at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyler.l.owen at gmail.com




------- Additional Comments From tyler.l.owen at gmail.com  2007-06-19 20:52 EST -------
This is not an official review as I am not sponsored yet.


---------
Summary:
---------
* rpmlint output not silent
* license file not included in RPM
* no %doc defined in %files
* Changelog missing version information
* Files section needs work.
* Create a devel package with correct files.  Not in the main package
* Use macros for %build and %install sections

---------
Details:
---------

 OK - Mock : Built on F-7 (x86)
 OK - Package meets naming and packaging guidelines
 OK - Spec file matches base package name.
 FIX - Spec has consistant macro usage.
 FIX - Meets Packaging Guidelines.
 OK - License field in spec matches
 OK - License is GPL
 OK - License match packaging policy licenses allowed
 FIX - License file is included in package
        License should be included as %doc in the %files section
 OK - Spec in American English
 OK - Spec is legible.
 OK - Sources SHOULD match upstream md5sum:
efd0c958da79c1cd941ecd3f63e637ae  dbench-3.04.tar.gz
 OK - Package has correct buildroot.
 OK - BuildRequires are not redundant.
 FIX - %build and %install stages are correct and work.
        why not use, for %prep:
        %setup -q

        This would eliminate the need for the pushd and popd

        For %install why not use:
        make install DESTDIR=$RPM_BUILD_ROOT

        It would simplify the %install to 1 line (besides the rm -rf
$RPM_BUILD_ROOT), not to mention it would only install
        the files that are required for the main RPM needed to work


 OK - Package has %defattr and permissions on files is good.
 OK - Package has a correct %clean section.
 OK - Package is code or permissible content.
 FIX - Packages %doc files don't affect runtime.
        There is no %doc section
 OK - No large doc files not in a -doc package
 FIX - Package has no duplicate files in %files.
        %files section needs work
 OK - Package doesn't own any directories that other packages own.
 FIX - Changelog section is correct. 
 NA - Does not contain any .la libtool archives
 NA - .desktop file installed correctly

 FIX - Should function as described.
       Binary installs and will run, but package installs binary to
/usr/share/dbench which isn't a typical place for a binary thus not in $PATH
 OK - Should package latest version

---------------
Rpmlint output:
---------------
SRPM
        W: dbench no-url-tag
        W: dbench mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 6)

RPM
        W: dbench no-documentation
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/io.c
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/snprintf.c
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/child.c
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/system.c
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/proto.h
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/config.h
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/util.c
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/sockio.c
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/fileio.c
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/tbench_srv.c
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/socklib.c
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/dbench.c
        W: dbench devel-file-in-non-devel-package /usr/share/dbench/dbench.h
        W: dbench no-version-in-last-changelog
        W: dbench no-url-tag
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/fileio.o
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/dbench
        W: dbench unstripped-binary-or-object /usr/share/dbench/dbench
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/tbench_srv
        W: dbench unstripped-binary-or-object /usr/share/dbench/tbench_srv
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/system.o
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/snprintf.o
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/util.o
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/child.o
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/tbench
        W: dbench unstripped-binary-or-object /usr/share/dbench/tbench
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/tbench_srv.o
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/sockio.o
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/socklib.o
        E: dbench arch-dependent-file-in-usr-share /usr/share/dbench/dbench.o



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.