[Bug 243642] Review Request: schroedinger - Portable libraries for the high quality Dirac video codec

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: schroedinger - Portable libraries for the high quality Dirac video codec


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243642


david at lovesunix.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From david at lovesunix.net  2007-06-20 03:52 EST -------
GOOD:
- rpmlint is silent
- Follows naming guidelines
- %{name} matches base package
- Meets packaging guidelines
- License is OSI approved or compatible
- %doc's all required files
- SPEC is in US English
- SPEC is both beautiful and fully readable
- source matches upstream release
- Compile tested fine on x86_64
- All BuildRequires present
- Locale handled correctly 
- Owns all files and directories
- ldconfig called in both post and postun
- Appears relocatable
- No duplicate entries in %files
- all %files sections contain %defattr and permissions appear correct
- Contains %clean and removes buildroot
- consistent use of macros 
- package contains actual code
- runs without documentation
- Headers are in -devel
- library files with a suffix are in -devel
- -devel requires %{name} = %{version}-%{release} 
- no -la files
- does not own files or directories already owned by other packages
- cleans out buildroot before install
- SPEC is valid UTF-8

BAD:
- License field should read LGPL/MIT/MPL as reported by upstream
- -devel package must Requires: pkgconfig as it contains a .pc file

APPROVED, just fix the license field and the Requires before checking this in.
Thank you, if you need a comaintainer for those vacation times and such I'll
happily help out.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.