[Bug 245045] Review Request: re2c - Tool for generating C-based recognizers from regular expressions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: re2c -  Tool for generating C-based recognizers from regular expressions


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245045


Jochen at herr-schmitt.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |Jochen at herr-schmitt.de
               Flag|                            |fedora-review?




------- Additional Comments From Jochen at herr-schmitt.de  2007-06-20 14:39 EST -------
Good:
+ Naming is ok.
+ Tar ball matches with upstream.
+ Naming seems ok.
+ Rpmlint quite on source rpm.
+ Local build works fine.
+ Rpmlint quite on binary rpm.
+ Rpmlint quite on debuginfo rpm.
+ Filelist of binary rpm looks ok.
+ Local install and uninstall of the package works fine.
+ Mock build works fine.

Bad:
- SPEC file specified MIT license but homepage of the project
  declare that the software may distribute as Public Domain.
- Package contains no verbatin copy of the license.
  (This is not a blocker. Please ask upstream to include
   a verbatin copy of the license text into the tar ball)







-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.