[Bug 226599] Merge Review: xorg-x11-drv-i810

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: xorg-x11-drv-i810


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226599


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2007-06-20 23:32 EST -------
Abbreviated mass review of xorg-x11-drv-* packages.

30d0cd555d8b8b5bb53d93eaae1ad2aecb5c94a760e2346d60b6e194c254e40f 
xf86-video-i810-1.6.5.tar.bz2
d563e47e908710b0c4c5122237b05a977b16d5c7a57e69c880a885014102e695 
xf86-video-intel-2.0.0.tar.bz2

Is there an upstream source for the xf86-video-intel-2.0.0.tar.bz2 file?  Yes,
it seems to be the same as the legacy driver;  I suggest changing Source1: to
ftp://ftp.x.org/pub/individual/driver/xf86-video-intel-%{version}.tar.bz2

rpmlint has a few things to complain about:
W: xorg-x11-drv-i810-devel no-documentation
W: xorg-x11-drv-i810-devel no-documentation
W: xorg-x11-drv-i810 mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 3)
The usual.

E: xorg-x11-drv-i810 configure-without-libdir-spec
This is bogus because --libdir is passed in ${OPTS}.  However, these are regular
autoconf-generated scripts.  Can they not be called as usual with %configure? 
Not doing so misses out on those fancy Fedora CFLAGS and such, although -g is
there on the gcc command lines so the debuginfo package comes out OK.

E: xorg-x11-drv-i810 library-without-ldconfig-postin /usr/lib64/libI810XvMC.so.1.0.0
E: xorg-x11-drv-i810 library-without-ldconfig-postun /usr/lib64/libI810XvMC.so.1.0.0
I think you do want to call ldconfig here.

W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0 XFree
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmAvailable
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
XvMCQueryExtension
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmGetMagic
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmOpen
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmMap
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmCommandNone
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmUnlock
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
XGetGeometry
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
_xvmc_destroy_subpicture
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmCommandWriteRead
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmClose
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
_xvmc_destroy_surface
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
_xvmc_create_surface
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
XInternAtom
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
_xvmc_create_subpicture
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
_xvmc_create_context
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
_xvmc_destroy_context
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
XvMCQueryVersion
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmUnmap
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
XQueryTree
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmGetLock
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmUnmapBufs
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
drmCommandWrite
W: xorg-x11-drv-i810 undefined-non-weak-symbol /usr/lib64/libI810XvMC.so.1.0.0
XvGetPortAttribute
I'm not sure what's up with these.  This would generally seem to break linking,
but I know that X modules in general and the XvMC libraries in particular are
rather strange.  I'm sure you know what's up here; can you give me a hint?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.