[Bug 245160] Review Request: fann - A fast artificial neural network library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fann - A fast artificial neural network library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245160


tyler.l.owen at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyler.l.owen at gmail.com




------- Additional Comments From tyler.l.owen at gmail.com  2007-06-21 21:20 EST -------
This is not an official review as I am not sponsored yet.


---------
Summary:
---------
* Main RPM includes .so
(http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7)
* fan-devel should not include .la files
(http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7)
* fann-devel ships a pkgconfig file (.pc), it should have "Requires: pkgconfig"
* Source0 is not set to the standard for Sourceforge
(http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2)

---------
Details:
---------

 OK - Mock : Built on F-7 (x86)
 OK - Package meets naming and packaging guidelines
 OK - Spec file matches base package name.
 OK - Spec has consistant macro usage.
 OK - License field in spec matches
 OK - License is LGPL
 OK - License match packaging policy licenses allowed
 OK - License file is included in package
 OK - Spec in American English
 OK - Spec is legible.
 OK - Sources SHOULD match upstream md5sum:
4224efa533265dcf39237667973d0e20  fann-2.0.0.tar.bz2
 OK - Package has correct buildroot.
 OK - BuildRequires are not redundant.
 OK - %build and %install stages are correct and work.
 OK - Package has %defattr and permissions on files is good.
 OK - Package has a correct %clean section.
 OK - Package is code or permissible content.
 OK - Packages %doc files don't affect runtime.
 OK - No large doc files not in a -doc package
 OK - Package has no duplicate files in %files.
 OK - Package doesn't own any directories that other packages own.
 OK - Changelog section is correct. 
 FIX - Does not contain any .la libtool archives
 NA - .desktop file installed correctly

 ? - Should function as described. 
        No way to test
 OK - Should package latest version

---------------
Rpmlint output:
---------------
* rpmlint fann-2.0.0-0.fc7.src.rpm
        silent
* rpmlint fann-2.0.0-0.fc7.i386.rpm 
        W: fann devel-file-in-non-devel-package /usr/lib/libfloatfann.so
        W: fann devel-file-in-non-devel-package /usr/lib/libfann.so
        W: fann devel-file-in-non-devel-package /usr/lib/libdoublefann.so
        W: fann devel-file-in-non-devel-package /usr/lib/libfixedfann.so

* rpmlint fann-devel-2.0.0-0.fc7.i386.rpm

----------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.