[Bug 244951] Review Request: apr-api-docs - Apache Portable Runtime API documentation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: apr-api-docs - Apache Portable Runtime API documentation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244951


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
               Flag|                            |fedora-review?




------- Additional Comments From kevin at tummy.com  2007-06-21 23:20 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (Apache)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
aa51ef5ee3063f456c07430aa20b0f49  doxygen.conf
aa51ef5ee3063f456c07430aa20b0f49  doxygen.conf.1
210107e33110270ff1e20db6c1ac9dc8  LICENSE
210107e33110270ff1e20db6c1ac9dc8  LICENSE.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
See below - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
See below - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag

Issues:

1. Why the
rm -rf %{name}-%{version}
in clean?

2. Your Source1 has a typo in it:
Source1:        http://svn.apache.org/repos/asf/apr/apr/tags/%{version}}/LICENSE

Note the }} there.

3. rpmlint, or pal says:

W: apr-api-docs mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1)

Fix if you get a chance.

E: apr-api-docs no-binary

As you say, this can be ignored.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.