[Bug 231267] Review Request: stardict-dic - dictionaries for StarDict

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: stardict-dic - dictionaries for StarDict


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231267


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: stardict-   |Review Request: stardict-dic
                   |dic-zh_CN - Simplified      |- dictionaries for StarDict
                   |Chinese(zh_CN) dictionaries |
                   |for StarDict                |
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-06-22 02:36 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
0349198b9dfcecd9a0f505512bb21d8b  stardict-cdict-big5-2.4.2.tar.bz2
68e539f362de416490b78fed97aba780  stardict-cdict-gb-2.4.2.tar.bz2
80b13d05bd5e975c35afcf4a13113673  stardict-cedict-big5-2.4.2.tar.bz2
d8db9bdbf0dd4856d03e04d3f73d9c5a  stardict-cedict-gb-2.4.2.tar.bz2
f164dcb24b1084e1cfa2b1cb63d590e6  stardict-dictd_www.dict.org_wn-2.4.2.tar.bz2
109c2308393a9bde37413cd1305e1256  stardict-dic-zh_CN-2.4.2.tar.bz2
0aa46b7d589a01663c3fb465152db85d  stardict-edict-2.4.2.tar.bz2
e0f60d6acc4e3df6784805816b2e136f  stardict-jmdict-en-ja-2.4.2.tar.bz2
2c574aef86a5d7bab45395d7e8ee7f6b  stardict-jmdict-ja-en-2.4.2.tar.bz2
50b9423fa578988b5b0544c5b663058a  stardict-langdao-ce-big5-2.4.2.tar.bz2
8e9700798a0ffeed23207b7cf2592246  stardict-langdao-ce-gb-2.4.2.tar.bz2
61ceeec1b056a171645af723d3e956fe  stardict-langdao-ec-big5-2.4.2.tar.bz2
41a71f5b3952709746dd7e52cf155b8b  stardict-langdao-ec-gb-2.4.2.tar.bz2
096f25252d2809191ff4fea041364841  stardict-mueller7-2.4.2.tar.bz2
e54da1d0759ce59f8fbddff7979e9300  stardict-oxford-big5-2.4.2.tar.bz2
c175f9bcb88e7513380ad05b291a8a03  stardict-oxford-gb-2.4.2.tar.bz2
4467d7941f9388f0e01ee3025c400b5c  stardict-stardict1.3-2.4.2.tar.bz2
745727367e22ab9740256ceaf16cb83d  stardict-xdict-ce-gb-2.4.2.tar.bz2
364bcecc126d6d8560728dc487ea9eaf  stardict-xdict-ec-gb-2.4.2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
- License text is NOT included in package.
+ %doc is small so no need of -doc subpackage.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains content.
+ no static libraries.
+ no .pc files are present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.