[Bug 245357] Review Request: libopensync-plugin-syncml - plugin for using syncml with opensync

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libopensync-plugin-syncml - plugin for using syncml with opensync


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245357


tyler.l.owen at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyler.l.owen at gmail.com




------- Additional Comments From tyler.l.owen at gmail.com  2007-06-22 14:22 EST -------
This is not an official review as I am not sponsored yet.


---------
Summary:
---------
* Does not build in mock, missing BuildRequires: pkgconfig
* Changelog needs some work
* %doc contains empty files

---------
Details:
---------

* FIX - Mock : Built on F-7 (x86)
        Did not build: (needs BuildRequires: pkgconfig
                checking for pkg-config... no
                checking for PACKAGE... configure: error: The pkg-config script
could not be found or is too old.  Make sure it
                is in your PATH or set the PKG_CONFIG environment variable to
the full
                path to pkg-config.

 OK - Package meets naming and packaging guidelines
 OK - Spec file matches base package name.
 OK - Spec has consistant macro usage.
 OK - License field in spec matches
 OK - License is GPL
 OK - License match packaging policy licenses allowed
 OK - License file is included in package
 OK - Spec in American English
 OK - Spec is legible.
 OK - Sources SHOULD match upstream md5sum:
8ffa3233ad28fb3ead324d88573f0c38  libopensync-plugin-syncml-0.22.tar.bz2
 OK - Package has correct buildroot.
 OK - BuildRequires are not redundant.
 FIX - %build and %install stages are correct and work.
        Does not build
 OK - Package has %defattr and permissions on files is good.
 OK - Package has a correct %clean section.
 OK - Package is code or permissible content.
 OK - Packages %doc files don't affect runtime.
 OK - No large doc files not in a -doc package
 OK - Package has no duplicate files in %files.
 FIX - Package %files & %doc looks good
        %doc contains empty files - README and NEWS
 ? - Package doesn't own any directories that other packages own.
 FIX - Changelog section is correct. 
        either needs a "-" infront of it or move it up to the above line
* NA - Does not contain any .la libtool archives
 NA - .desktop file installed correctly

 ? - Should function as described.
 OK - Should package latest version

---------------
Rpmlint output:
---------------
* SRPM
        OK - silent
* RPM
        ?- rpm didn't build



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.