[Bug 245485] Review Request: fityk-0.8.1 - curve-fitting program for X-Y data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fityk-0.8.1 - curve-fitting program for X-Y data


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245485





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-06-24 01:55 EST -------
Spot, did you change the spec file? Then please
upload a new srpm.

Notes:
* Variables
  - Please check what %configure does and do not set unneeded
    variables.
    E.g. CXXFLAGS="$RPM_OPT_FLAGS": not needed
       CC="%{?ccache} gcc" CXX="%{?ccache} g++" also not needed
* Debuginfo
  - LDFLAGS="-s" is strictly forbidden

* Timestamps
  - Please add 'INSTALL="%{__install}" -p" option to
    'make install' to keep timestamps
  - And use "install -p" when using install command

* Seemingly unneeded scripts
  - When I do "make install", the following scripts are
    automatically done and seem unneeded
-------------------------------------------------------
#icons
install -m644 -D %{name}.png %{buildroot}/%{_datadir}/icons/%{name}.png
#tips file
install -m644 -D src/wxgui/tips.txt %{buildroot}/%{_datadir}/%{name}/fityk_tips.txt
--------------------------------------------------------

* scriptlets
  - Please explain why the call of update-mime-database is needed
    (Check the section "mimeinfo" of
     http://fedoraproject.org/wiki/Packaging/ScriptletSnippets )

* Requires
---------------------------------------------------------
Requires:	desktop-file-utils shared-mime-info
---------------------------------------------------------
  These two should be removed (these two seem to be added
  by spot)

  

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.