[Bug 245488] Review Request: maradns - security-aware DNS server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: maradns - security-aware DNS server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245488


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ruben at rubenkerkhof.com




------- Additional Comments From ruben at rubenkerkhof.com  2007-06-24 05:51 EST -------
Hi Brandon,

Nice, another dns server ;-)

Some initial comments:

rpmlint of maradns:
W: maradns wrong-file-end-of-line-encoding /usr/share/doc/maradns-
1.2.12.06/pt_br/source/compile.ej
W: maradns wrong-file-end-of-line-encoding /usr/share/doc/maradns-
1.2.12.06/pt_br/source/authoritative.ej
W: maradns spurious-executable-perm /usr/share/doc/maradns-1.2.12.06/en/man/make.pdf
W: maradns wrong-file-end-of-line-encoding /usr/share/doc/maradns-
1.2.12.06/pt_br/source/dangling.ej
W: maradns wrong-file-end-of-line-encoding /usr/share/doc/maradns-
1.2.12.06/en/misc/compression/decompress_api.html
W: maradns spurious-executable-perm /usr/share/doc/maradns-1.2.12.06/en/tutorial/make.index
W: maradns wrong-file-end-of-line-encoding /usr/share/doc/maradns-
1.2.12.06/pt_br/source/zoneserver.ej
W: maradns spurious-executable-perm /usr/share/doc/maradns-1.2.12.06/en/webpage/make.page
W: maradns wrong-file-end-of-line-encoding /usr/share/doc/maradns-
1.2.12.06/pt_br/source/csv2.ej
W: maradns wrong-file-end-of-line-encoding /usr/share/doc/maradns-
1.2.12.06/en/misc/private_rrs.html
E: maradns no-status-entry /etc/rc.d/init.d/maradns
W: maradns no-reload-entry /etc/rc.d/init.d/maradns
E: maradns subsys-not-used /etc/rc.d/init.d/maradns
E: maradns no-status-entry /etc/rc.d/init.d/maradns-zoneserver
W: maradns no-reload-entry /etc/rc.d/init.d/maradns-zoneserver
E: maradns subsys-not-used /etc/rc.d/init.d/maradns-zoneserver

- The FAQ etc are installed twice, once as FAQ and once as FAQ.txt
- Missing dependancy on chkconfig for %post (package chkconfig)
- Missing dependancy on chkconfig for %preun (package chkconfig)
- Missing dependancy on service for %postun (package initscripts)
- Missing dependancy on service for %preun (package initscripts)

The way of building this package is a bit strange. The Makefile calls ./compile.sh, which in turn calls 
./configure and then make again. This way, $RPM_OPT_FLAGS are not used.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.