[Bug 244374] Review Request: xulrunner - XUL Runner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xulrunner - XUL Runner


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244374





------- Additional Comments From kengert at redhat.com  2007-06-25 16:03 EST -------
You are trying to compile beta code that is not yet supported by the system NSPR
version.

The code is only available on the latest NSPR branch that is heading to 4.7.
Unfortunately, as of today, there is no 4.7 based release yet.


I'm ok to build a new NSPR 4.6.x based RPM for Rawhide that includes the latest
upstream patch. Since this is only a forward to another function, we should be fine.


But note the patch quoted in comment 30 is no longer current, a different patch
got landed on upstream NSPR, see bug 375985.

I propose we include the following patch:

Index: mozilla/nsprpub/pr/include/prlog.h
diff -u mozilla/nsprpub/pr/include/prlog.h:3.14
mozilla/nsprpub/pr/include/prlog.h:3.15
--- mozilla/nsprpub/pr/include/prlog.h:3.14     Sun Apr 25 15:00:47 2004
+++ mozilla/nsprpub/pr/include/prlog.h  Mon May 28 14:48:26 2007
@@ -251,6 +251,14 @@

 #endif /* defined(DEBUG) || defined(FORCE_PR_ASSERT) */

+/*
+** Compile-time assert. "condition" must be a constant expression.
+** The macro can be used only in places where an "extern" declaration is
+** allowed.
+*/
+#define PR_STATIC_ASSERT(condition) \
+    extern void pr_static_assert(int arg[(condition) ? 1 : -1])
+
 PR_END_EXTERN_C

 #endif /* prlog_h___ */


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.