[Bug 243109] Review Request: loki-lib - Loki C++ Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: loki-lib - Loki C++ Library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243109


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2007-06-25 16:56 EST -------
rpmlint is clean now.  Some concerns I have:

The summary isn't very descriptive.

Your release should start with one and should be an integer unless the naming
guidelines specify otherwise.

All of the .cpp source files are in the debuginfo package, but only a few of the
.h files are.  I have no idea why.  Perhaps they're not used in compilation but
are installed as additional usable templates?

A readme.txt file is installed into /usr/include.

So, just comment on those and fix them if you think they're fixable and we're
good to go.

Review:
* source files match upstream:
   b2dbf0c89098a4c51822bae767bf0c33650f206caad848eaea37b61e8f482395  
   loki-0.1.6.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
 summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream (It's in each source file and scattered 
  throughout the documentation but not actually included in a separate file.)
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64[).
* package installs properly
? debuginfo package might be complete; I can't tell.
* rpmlint is silent.
* final provides and requires are sane:
  loki-lib-0.1.6-0.3.fc8.x86_64.rpm
   libloki.so.0.1.6()(64bit)
   loki-lib = 0.1.6-0.3.fc8
  =
   /sbin/ldconfig
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)

  loki-lib-devel-0.1.6-0.3.fc8.x86_64.rpm
   loki-lib-devel = 0.1.6-0.3.fc8
  =
   libloki.so.0.1.6()(64bit)
   loki-lib = 0.1.6-0.3.fc8

  loki-lib-doc-0.1.6-0.3.fc8.x86_64.rpm
   loki-lib-doc = 0.1.6-0.3.fc8
  =

* %check is not present; the included test suite doesn't seem to work.
* shared libraries present; ldconfig is called properly.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (ldconfig)
* code, not content.
* documentation is in a -doc subpackage.
* %docs are not necessary for the proper functioning of the package.
* headers are in -devel subpackage.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.