[Bug 239435] Review Request: Gnome Network Monitor - A Network Monitor for the GNOME Desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Gnome Network Monitor - A Network Monitor for the GNOME Desktop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239435





------- Additional Comments From Jochen at herr-schmitt.de  2007-06-26 13:48 EST -------
Good:
+ Package meat naming guideline
+ Name of SPEC file meat base package name
* Package contains %{?dist} tag
+ Consistent usage of RPM macros
+ Package meets packaging guideline
+ License of the package is GPL
+ License field in SPEC file matches
+ SPEC is written in englisch
+ SPEC look legible
+ Tar ball in source RPM metaches with upstream
  md5sum: 5e9eb652e4e24e2057f6eb1b4794a683 
+ Package has correct buildroot
+ BuildRequires are not redundant
+ Package contains no sub packages
+ Local build works fine
+ SPEC file contains proper %defattr and %attr permission
+ Package has a correct %clean section
+ $RPM_BUILD_ROOT will be cleaned on start of %install section
+ Packages %doc section doesn't affect runtime.
+ %files section contains no duplicate files
+ Package contains no file or directories own by other packages.
+ Changelog section is correct.
+ Rpmlint is quite of source and binary rpm.
+ Mock build wors fine on Devel and F-7 (x86_64)

+ Package should contains the most recent version.
+ Startup of the package works without crash.

Bad:
- License file should be includes from tar ball.
- BR on gettext-devel may be better, because gettext-devel comtains
  development tools which are not in the gettext package.
- Wrong Requires:
  You use:
Requires(post):   /usr/bin/update-desktop-database
Requires(postun): /usr/bin/update-desktop-database

because you use desktop-file-install in your scriplets, you shoud
have the following in your Requires:

Requires(post):   /usr/bin/desktop-file-install
Requires(postun): /usr/bin/desktop-file-install

- Package does not sure the ownership of the directory 
   %{python_sitelib}/%{name}/

The best way to make sure, that the directory and all files belong to the
package is to write

%{python_sitelib}/%{name}/

into the SPEC file, so you can remove the line

%{python_sitelib}/%{name}/*.py*

from the SPEC file.

- Desktop entry contains no icon.






-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.