[Bug 240557] Review Request: ocaml-findlib - Objective CAML package manager and build helper

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-findlib - Objective CAML package manager and build helper


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240557





------- Additional Comments From rjones at redhat.com  2007-06-26 23:56 EST -------
http://annexia.org/tmp/ocaml/ocaml-findlib-1.1.2pl1-6.src.rpm
http://annexia.org/tmp/ocaml/ocaml-findlib.spec

> Mock failed to build on F-7_x86_64:

This is the first time I've tried "mock".  It turned out there was
a missing BuildRequires (ncurses-devel), which I fixed.  However I
wasn't able to get mock to install ocaml 3.10.0 (which is required)
because that RPM isn't in Fedora yet.  What I'd like it to do is
to create the chroot environment, get all the packages, then install
my ocaml 3.10.0 package before starting the build.

The updated ocaml 3.10.0 package is here: http://math.ifi.unizh.ch/fedora/tmp/
or see bug 239004.

Anyhow, if you can work out how to do that, then the updated
SRPM should work.

> Your release tag doesn't quite good.
> As your package contains pre-release it should be more like this:
> 1.1.2-0.1.pl1 instead of 1.1.2pl1-1

I don't understand what this means.  The upstream package is
called 1.1.2pl1, so I just added a release number.

> typo: from %build stage
> -bindir %{_bindir} instead of -bindir %{_mandir}

Fixed.  This didn't seem to have any effect, but it's obviously
wrong.

> About -config %{_sysconfdir}/ocamlfind.conf, its provided by this package

The configure argument apparently tells the package where to
create/install that file, not where to find it.

I also made the changes to %doc.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.