[Bug 241403] Review Request: qgis - A user friendly Open Source Geographic Information System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qgis - A user friendly Open Source Geographic Information System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241403





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-06-27 09:04 EST -------
Sorry for delay.

For 0.8.1-3: Almost okay.

* Desktop file
  - qgis is a GUI program and the corresponding desktop
    file should be created and installed.
    Please check: "Desktop files" section of
    http://fedoraproject.org/wiki/Packaging/Guideline

    NOTE: Please remember to add "desktop-file-utils" to
          BuildRequires.

* Documents
  - IMO the following files can be added to %doc
--------------------------------------------------
CONTRIBUTORS
--------------------------------------------------

? Dependency
  - By the way, Does qgis-grass not depend on grass?
    (currently while qgis depends on grass-libs,
     it does not require grass itself. This is a
     QUESTION, not blocker)

? %check
  - tarball contains tests/ directory. Can qgis do
    some test program like "make check" at build stage?
    If so, add %check stage and do some check program
    in %check stage.

? Files with white spaces
  - Just a question: some files have names with white spaces.
    Is it okay?

Well, as this is a sponsor needed tickets:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.