[Bug 244623] Review Request: OggConvert - OggConvert is a small GNOME utility that uses GStreamer to convert media files to the licence-free Theora and Vorbis formats.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OggConvert - OggConvert is a small GNOME utility that uses GStreamer to convert media files to the licence-free Theora and Vorbis formats.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244623





------- Additional Comments From bdpepple at ameritech.net  2007-06-27 15:32 EST -------
MD5Sums:
a825bf00977e3410f9009198dbcc1fbb  oggconvert-0.2.0.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* All desired features are enabled

Bad
* Unnecessary Requires on python. In general you don't need to require python
since python packages require the python(abi).

* Directory ownership is incorrect for '%{python_sitelib}/OggConvert'.  you
should use '%{python_sitelib}/OggConvert/', instead of
'%{python_sitelib}/OggConvert/*' to correct this.

* Desktop file does not have the vendor set to 'fedora'.  Also the desktop file
contains the depreciated category 'Application'.  You need to add
'--remove-category=Application' to your desktop-file-install call to fix this.

* rpmlint produces the following errors:
E: oggconvert non-executable-script
/usr/lib/python2.5/site-packages/OggConvert/ocv_info.py 0644
E: oggconvert non-executable-script
/usr/lib/python2.5/site-packages/OggConvert/__init__.py 0644
E: oggconvert non-executable-script
/usr/lib/python2.5/site-packages/OggConvert/ocv_util.py 0644
E: oggconvert non-executable-script
/usr/lib/python2.5/site-packages/OggConvert/ocv_gtk.py 0644
E: oggconvert non-executable-script
/usr/lib/python2.5/site-packages/OggConvert/ocv_gst.py 0644
E: oggconvert explicit-lib-dependency libglade2
E: oggconvert description-line-too-long OggConvert is a small GNOME utility that
uses GStreamer to convert media files to the patent-free Theora and Vorbis
formats. It's painfully easy to use: drag a file onto the source bar (or use the
file chooser) and hit convert. Of course, you can also change the quality
settings and the output filename if you like. It uses GStreamer, so it can
convert (almost) any file which Totem can play. It can deal with audio-only
files, video-only files, and files with many audio tracks (such as DVD rips with
a commentary track). Thanks to the magic of GStreamer, metadata (for example,
title and artist info on an MP3) is preserved. Finally, it adheres to the GNOME
HIG as much as possible.

* It builds in Mock, but there are some compiling errors that should be looked
at for example:
<snip>
***MEMORY-WARNING***: [2744]: GSlice: g_thread_init() must be called before all
other GLib functions; memory corruption due to late invocation of
g_thread_init() has been detected; this program is likely to crash, leak or
unexpectedly abort soon...
</snip>
I'll attach my build log for you to go through, and look at.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.