[Bug 241081] Review Request: R-widgetTools-1.12.0-2 - Tools to support the construction of tcltk widgets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-widgetTools-1.12.0-2 - Tools to support the construction of tcltk widgets


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241081





------- Additional Comments From tibbs at math.uh.edu  2007-06-27 17:49 EST -------
This one looks much better.  Oddly the spec file has become executable, which
elicits the following from rpmlint:
   W: R-widgetTools strange-permission R-widgetTools.spec 0755
I don't think this is anything to worry about.

I'm confused by the dependencies.  This pachage seems to have no requirements
besides /bin/sh needed to run the scriptlets.  Shouldn't it depend on R as well
as tcl and tk?

The final package is mostly documentation.  The whole package isn't huge so I
don't think it's mandatory that it be split into a -doc subpackage and I know
that R has its own internal documentation browser system,  but I still have to
wonder if the documentation in this package shouldn't be marked as %doc so a
smaller --excludedocs installation is possible.  The question is simple: does
the package still work if you delete all of the documentation files.  If so,
those files should all be marked as %doc.

And I certainly agree, guidelines for R packages would be a great idea as they
would answer all of these questions I keep having.  I, however, am certainly not
the person who should be writing them.

Review:
* source files match upstream:
   50c37833547bf50553a2bfe3a3426ec798eb066c29df9581f0ad50180a961974  
   widgetTools_1.12.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint has only acceptable complaints.
X final provides seems to be missing something
   R-widgetTools = 1.12.0-5.fc8
  =
   /bin/sh

* %check is present but cannot be run without additional dependencies and can't 
   be run in mock in any case.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (R documentation index generation)
* code, not content.
? documentation is a bit larger than the actual code.  It might be worth 
   splitting.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.