[Bug 239385] Review Request: peless - Text Browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: peless - Text Browser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239385


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-06-28 13:28 EST -------
Well, again read the spec files of other packages and guidelines 
on the URL above then rewrite the spec file.

* Don't use unneeded macros. Why do you have to define %_build_requires
  or so? 
* Don't use date for release number unless the source is cvs, svn,
  or so. For formal release tarball, release number must be
  <simple integer>%{?dist} except for some exceptions.
* For Requires, please don't like explicit packages' requirements
  which are automatically checked by rpmbuild by libraries' dependency
  check.
* vendor tag must not be used 
* rewrite the part of calling configure with %configure macro
* [ "$RPM_BUILD_ROOT" != "/" ]
  $RPM_BUILD_ROOT must not / and this should be removed.
* install-strip is forbidden. This disables to create debuginfo rpm.
* rm -rf $RPM_BUILD_DIR/file.list.%{name}
  .....
  All of these are not needed. %clean automatically removes
  $RPM_BUILD_DIR
  

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.