[Bug 246117] Review Request: drawtiming - A command line tool for generating timing diagrams

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: drawtiming - A command line tool for generating timing diagrams


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246117


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-06-28 20:11 EST -------
Not much to say; a simple, clean package.

Review:
* source files match upstream:
   db5b65121d5f2c27a3d65a22f9a9ea1699f6c6a923adff56b714ae6e276585f9  
   drawtiming-0.6.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   drawtiming = 0.6.2-1.fc8
  =
   libICE.so.6()(64bit)
   libMagick++.so.10()(64bit)
   libMagick.so.10()(64bit)
   libSM.so.6()(64bit)
   libWand.so.10()(64bit)
   libX11.so.6()(64bit)
   libXext.so.6()(64bit)
   libXt.so.6()(64bit)
   libbz2.so.1()(64bit)
   libfontconfig.so.1()(64bit)
   libfreetype.so.6()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libjpeg.so.62()(64bit)
   liblcms.so.1()(64bit)
   libpthread.so.0()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   libtiff.so.3()(64bit)
   libz.so.1()(64bit)
* %check is present and all tests pass:
   PASS: runsamples.sh
   ==================
   All 1 tests passed
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.