[Bug 245499] Review Request: python-elixir - A declarative mapper for SQLAlchemy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-elixir - A declarative mapper for SQLAlchemy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245499


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-06-28 21:05 EST -------
Thanks to Steve for the test output; I'd have no idea how to test this myself.

The only issues I can see are a few documentation files which should probably be
included: CHANGES and TODO.

If you agree, just go ahead and add them when you check in.

Review:
* source files match upstream:
   ee5feb9ecd7a0991528fbb3d2d781be4e5f0389f11a62bce11641d70bdbc444b  
   Elixir-0.3.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   python-elixir = 0.3.0-1.fc8
  =
   python(abi) = 2.5
   python-sqlalchemy
* %check is not present (no test suite upstream) but see above for manual 
   testing.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.