[Bug 246286] Review Request: xcb-proto - XCB protocol descriptions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xcb-proto - XCB protocol descriptions


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246286





------- Additional Comments From tibbs at math.uh.edu  2007-06-29 18:00 EST -------
I'm going to treat this as a development package, since that's really what it
is.  Thus the only rpmlint complaint:
  W: xcb-proto devel-file-in-non-devel-package /usr/share/pkgconfig/xcb-proto.pc
is not problematic.

It might be nice to define XCB in the description as a courtesy to those who
might stumble across this package.

Nothing seems to own /usr/share/xcb.  That's the only real issue I see.

* source files match upstream:
   df3ce807139957a9d3bd196a6eb5fad1d04af079d47b0ec36502911520b84e08  
   xcb-proto-1.0.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   xcb-proto = 1.0-1.fc8
  =
   pkgconfig
* %check is not present; there's nothing to test.
X doesn't own /usr/share/scb
* doesn't own any directories it shouldn't.
* no duplicates in %files.
 file permissions are appropriate.
* no scriptlets present.
* no code, but acceptable content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.