[Bug 244346] Review Request: mailutils - Collection of GNU mail-related utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mailutils - Collection of GNU mail-related utilities
Alias: mailutils-review

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244346


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2007-06-30 07:51 EST -------
You don't use some features, like
libgsasl, guile, or emacs-mh. I think these should be shipped.

I think it is bad to conflict with nmh. I think that
you should use 
--with-mh-bindir
instead.

Some suggestions:

* put the %post and friends before the %files section. There is no
  reason, except that it is how all the other spec files are done
  in fedora.

* use wildcards for man pages and info pages in %files, like
%{_infodir}/%{name}.info*

%{_mandir}/man1/popauth.1*

* don't use .gz in the install-info %preun, install-info is able to
  figure out itself what compression it should use.

* use 
rm $RPM_BUILD_ROOT/%{_libdir}/%{name}/*.a
instead of
rm -f $RPM_BUILD_ROOT/%{_libdir}/%{name}/*.a
that way build will break if something changed upstream.

* It seems to me that COPYING.LESSER should be in libs %doc
  I also guess that devel subpackage is LGPL licensed.
  I would also add COPYING in all the subpackages, since 
  the doc subpackage may not be installed.

  Alternatively you could have all packages depend on -doc
  since it is tiny, and more like a common package that really
  a doc package in my opinion.

* since this package is heavily split it would be nice, in my 
  opinion, to try to have a similar layout than in other repos. 
  I haven't really found other repos packaging mailutils, except
  for alt linux, but I may have missed something. Maybe you could
  use the split from the upstream specfile, as long as it makes sense
  (no -dev subpackage, for example).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.