[Bug 222478] Review Request: sofsip-cli - SIP VoIP/IM example client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sofsip-cli - SIP VoIP/IM example client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222478


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
OtherBugsDependingO|163776                      |
              nThis|                            |
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-06-30 15:39 EST -------
sofia-sip is essentially done; I've placed it in a local repo so that I can
build this.

Hmm, a new version just came out within the last month.  I went ahead and bumped
the version and rebuilt just to make sure there were no major changes;
everything seems fine to me so I'll just approve this package and you can update
it when you check in.

For a CLI application, this sure has an amazing dependency list, including all
of X.  I guess that all comes along with the gstreamer-plugins requirements.

* source files match upstream:
   7aa8a02bee0aeb42be934aefeba058aff70b3a409e5b4113e9030a738b9c0800  
   sofsip-cli-0.12.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
X latest version is 0.13
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   sofsip-cli = 0.12-1.fc8
  =
   gstreamer-plugins-base
   gstreamer-plugins-farsight
   gstreamer-plugins-good
   libglib-2.0.so.0()(64bit)
   libgobject-2.0.so.0()(64bit)
   libncurses.so.5()(64bit)
   libpthread.so.0()(64bit)
   libpthread.so.0(GLIBC_2.2.5)(64bit)
   libreadline.so.5()(64bit)
   libsofia-sip-ua-glib.so.3()(64bit)
   libsofia-sip-ua.so.0()(64bit)
* %check is not present; no test suite upstream.  Frankly I have no idea how to 
   test this.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.