[Bug 245694] Review Request: php-pear-Phlickr - Phlickr is a PHP5 based api kit used with the Flickr API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Phlickr - Phlickr is a PHP5 based api kit used with the Flickr API


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245694


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-06-30 19:02 EST -------
Well, you don't have to use that precise download URL if it doesn't work for
you; it's just a suggestion.

Generally it's best to leave the package name out of the summary; otherwise you
get things like the subject of this ticket: "PackageName - PackageName is a...".

Also, there's no reason to provide a copy of the license if the upstream source
doesn't include it.

I tried to run the included test suite, but honestly I have no idea how to do
it.  I tried following the instructions on the upstream web site but I get no
output.

The above nonwithstanding, I don't see any blockers.

Review:
* source files match upstream:
   3acd972cc22d4f65a086eb739c2e4490bfae1a23c6c23febe0601afbe09f1013  
   Phlickr-0.2.7.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* license text included in package (supplied in the srpm).
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear(Phlickr) = 0.2.7
   php-pear-Phlickr = 0.2.7-2.fc8
  =
   /bin/sh
   /usr/bin/pear
   php-pear(PEAR)
* %check is not present.  There's a test suite, but I have no idea how to 
   actually run it.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module installation).
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.