[Bug 230324] Review Request: avrdude -Software for programming Atmel AVR Microcontroller

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: avrdude -Software for programming Atmel AVR Microcontroller


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230324





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-03-01 07:12 EST -------
Still needs some work.

MUST FIX:
=========
* rpmlint says:
[hans at shalem ~]$ rpmlint /usr/src/redhat/SRPMS/avrdude-5.3.1-3.src.rpm
/usr/src/redhat/RPMS/x86_64/avrdude-5.3.1-3.x86_64.rpm
/usr/src/redhat/RPMS/x86_64/avrdude-debuginfo-5.3.1-3.x86_64.rpm
E: avrdude info-dir-file /usr/share/info/dir
  Wether or not this happen may depend on the build environment (I don't
  use mock with my slow internet connection). So add:
  "rm -f $RPM_BUILD_ROOT%{_infodir}/dir"
  At the end of %install, the -f ensure that this won't cause the build to
  fail when the dir file isn't generated.
  
  And change under %files: "%{_infodir}/*" to "%{_infodir}/%{name}.info"
  I would like to recommend not to use too much wildcards under %files in
  general, so that errors like this one get caught by the checking for missing
  files check.

* Since you've enabled rebuilding off the docs, using the sed line I gave you on
  avrdude.info doesn't help, instead use it on avrdude.texi

* Since you've choosen for /etc/avrdude/avrdude.conf, you must also use sed
  to search replace /etc/avrdude.conf with /etc/avrdude/avrdude.conf in both
  doc/avrdude.texi and avrdude.1, like this:
  sed -i 's|/etc/avrdude.conf|/etc/avrdude/avrdude.conf|g' doc/avrdude.texi
avrdude.1


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.