[Bug 230726] Review Request: xmoto-edit - X-Moto level editor

bugzilla at redhat.com bugzilla at redhat.com
Fri Mar 2 18:11:39 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmoto-edit - X-Moto level editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726





------- Additional Comments From mr.ecik at gmail.com  2007-03-02 13:11 EST -------
(In reply to comment #3)
> Do you see anything else out of sorts?

I haven't even chcecked whether package's working, but at first sight I see 
that you ought to remove X-Fedora category and, if it exists, get rid of 
Application category as well. Also, if you put icons in %{_datadir}/icons/
hicolor you should add Requires: hicolor-icon-theme (some time ago it was 
discussed on list). Later I'm going to try to build this package and hopefully 
make the full review.

(In reply to comment #4)
> On second look, it's set that way in the Makefile.  Should I patch it and send
> it upstream?

IMHO you should.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list