[Bug 230726] Review Request: xmoto-edit - X-Moto level editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmoto-edit - X-Moto level editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726


mr.ecik at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
         AssignedTo|nobody at fedoraproject.org    |mr.ecik at gmail.com
               Flag|                            |fedora-review?,
                   |                            |needinfo?(limb at jcomserv.net)




------- Additional Comments From mr.ecik at gmail.com  2007-03-02 18:40 EST -------
REVIEW: 
** it seems that package has some unneeded dependencies, it built fine in mock 
with: SDL_mixer-devel, libGL-devel, libjpeg-devel, zlib-devel and libpng-devel. 
So you can get rid of curl-devel, ode-devel, lua-devel, libGLU-devel and 
replace bzip2-devel with zlib-devel (if there's something wrong with this set 
of dependencies, please let me know)

** does it make sense not to require main xmoto package? I understand that 
there's no need xmoto to be installed to make levels for it, but there's a 
"Play Level" button in xmoto-edit which ends up with very ugly "sh: xmoto: 
command not found". Thus add xmoto dependency.

** also, you have to add versioned xmoto dependency because of that: "file /usr/
bin/xmoto-edit from install of xmoto-edit-0.2.4-2.fc7 conflicts with file from 
package xmoto-0.2.2-2.fc6". Now I don't know whether it would be better to have 
xmoto >= 0.2.4 dependency or xmoto = %{version}. If xmoto and xmoto-edit 
versions always match, the second solution will be much more sane.

** rpmlint complain about W: xmoto-edit mixed-use-of-spaces-and-tabs (spaces: 
line 1, tab: line 12) so get rid of that

** [ecik at ecik ~]$ desktop-file-validate /usr/share/applications/fedora-xmoto-
edit.desktop
/usr/share/applications/fedora-xmoto-edit.desktop: warning: The 'Application' 
category is not defined by the desktop entry specification.  Please use one of 
"AudioVideo", "Audio", "Video", "Development", "Education", "Game", "Graphics", 
"Network", "Office", "Settings", "System", "Utility" instead

So just get rid of Application category in your desktop file. Install the 
newest rawhide version of desktop-file utils if you can't see this error on 
your desktop-file-validate.

** There's /usr/share/xmoto-edit/xmoto.bin file which contains a lot of binary 
(?) data. Is it arch-dependent? If so, you cannot put this file in %{_datadir}. 
Unfortunetaly, I'm unable to identify what kind of data it is, maybe you know 
something more?

** Desktop file contains "Comment=Xmoto LEvel Editor" - just change LEvel→Level

Other things seems ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.